Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eigenmode phase convention: choose real transverse fields for zero-thickness case #2422

Open
stevengj opened this issue Mar 2, 2023 · 0 comments

Comments

@stevengj
Copy link
Collaborator

stevengj commented Mar 2, 2023

Currently, our eigenmode solver chooses the phase to maximize the norm of Re(H), corresponding to fix-hfield-phase in MPB.

However, for a zero-thickness (i.e., constant-cross-section) eigenmode solve, there is a more common convention: choose the phase so that the transverse fields are purely real. It should be fairly easy to change our phase convention to match this case.

See also #2409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant