Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

periods for near2far adjoint #2321

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

mochen4
Copy link
Collaborator

@mochen4 mochen4 commented Nov 23, 2022

Supports periodic boundary condition for near2far adjoint. All the essential mechanism is already in place, so only an additional keyword argument is needed in python.

The k vector should be the same for forward and adjoint run. Since the adjoint sources are computed before flipping k, nothing needs to be changed.

@codecov-commenter
Copy link

Codecov Report

Merging #2321 (b74852f) into master (038a2e5) will decrease coverage by 1.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2321      +/-   ##
==========================================
- Coverage   73.23%   72.01%   -1.22%     
==========================================
  Files          17       17              
  Lines        4931     5031     +100     
==========================================
+ Hits         3611     3623      +12     
- Misses       1320     1408      +88     
Impacted Files Coverage Δ
python/adjoint/objective.py 92.38% <ø> (ø)
python/visualization.py 36.68% <0.00%> (-4.78%) ⬇️
python/simulation.py 76.81% <0.00%> (-0.05%) ⬇️
python/adjoint/optimization_problem.py 59.48% <0.00%> (+1.53%) ⬆️

@stevengj stevengj merged commit 9473d31 into NanoComp:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants