-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colorbars for plot2D #2289
Add colorbars for plot2D #2289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
You should also add this new feature to the |
Why not pass the default plotting options used in |
Thanks for the feedback! I think it's in much better shape now that I've:
Let me know what you think. |
LGTM! |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2289 +/- ##
==========================================
- Coverage 73.23% 73.06% -0.17%
==========================================
Files 17 17
Lines 4931 4952 +21
==========================================
+ Hits 3611 3618 +7
- Misses 1320 1334 +14
|
This PR:
plot2D
(both inplot_epsilon
andplot_fields
) (add epsilon colorbar for plot2D #2286)plot_fields
(Add Poynting components to plot_fields #2267)I think there's more room to improve the look of the colorbars, so let me know if I should make any adjustments!
So far fields look like this:
and epsilon looks like this:
@smartalecH
@joamatab
@SkandanC