Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorbars for plot2D #2289

Merged
merged 7 commits into from
Nov 3, 2022
Merged

Conversation

thomasdorch
Copy link
Contributor

This PR:

I think there's more room to improve the look of the colorbars, so let me know if I should make any adjustments!

So far fields look like this:
image
and epsilon looks like this:
image

@smartalecH
@joamatab
@SkandanC

Copy link
Collaborator

@oskooi oskooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

python/visualization.py Outdated Show resolved Hide resolved
@oskooi
Copy link
Collaborator

oskooi commented Oct 28, 2022

You should also add this new feature to the plot2D docstrings in simulation.py so that it is documented in the user manual.

@smartalecH
Copy link
Collaborator

Why not pass the default plotting options used in plot2D?

@thomasdorch
Copy link
Contributor Author

Thanks for the feedback!

I think it's in much better shape now that I've:

  • updated the docs in simulation.py @oskooi
  • added new argument, colorbar_parameters, that let the user specify parameters for the colorbar (including label) and pass them into plot2d @smartalecH

Let me know what you think.

@smartalecH
Copy link
Collaborator

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 53.96825% with 29 lines in your changes missing coverage. Please review.

Project coverage is 73.06%. Comparing base (5fa12b4) to head (7a87c62).
Report is 187 commits behind head on master.

Files with missing lines Patch % Lines
python/visualization.py 53.22% 29 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2289      +/-   ##
==========================================
- Coverage   73.23%   73.06%   -0.17%     
==========================================
  Files          17       17              
  Lines        4931     4952      +21     
==========================================
+ Hits         3611     3618       +7     
- Misses       1320     1334      +14     
Files with missing lines Coverage Δ
python/simulation.py 76.86% <100.00%> (+<0.01%) ⬆️
python/visualization.py 41.08% <53.22%> (-0.38%) ⬇️

@stevengj stevengj merged commit fdd5e0e into NanoComp:master Nov 3, 2022
@thomasdorch thomasdorch deleted the plot2d-improvements branch November 6, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants