Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3d material-grid test #2041

Closed
stevengj opened this issue Apr 14, 2022 · 0 comments · Fixed by #2049
Closed

3d material-grid test #2041

stevengj opened this issue Apr 14, 2022 · 0 comments · Fixed by #2049
Assignees

Comments

@stevengj
Copy link
Collaborator

Probably the smallest reasonable test would be something like what @oskooi did in the subpixel-smoothing papers: use a small unit cell periodic in all 3 dimensions, with e.g. a dielectric sphere, and compare the eigenfrequency (as returned by harminv) to the same structure with a material grid (with or without subpixel smoothing).

Any 3d test will still be relatively expensive, so we might not want it to run in CI, but have a make bigcheck option that includes it which we run occasionally (e.g. before releases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants