Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_unique doesn't compile with apple clang 13 #1843

Closed
stevengj opened this issue Dec 7, 2021 · 2 comments · Fixed by #1844
Closed

make_unique doesn't compile with apple clang 13 #1843

stevengj opened this issue Dec 7, 2021 · 2 comments · Fixed by #1844
Labels

Comments

@stevengj
Copy link
Collaborator

stevengj commented Dec 7, 2021

I'm getting

  CXX      GDSIIgeom.lo
GDSIIgeom.cpp:147:26: error: no member named 'make_unique' in namespace 'std'
    auto vertices = std::make_unique<vector3[]>(num_vertices);

on master with macOS 11.5.2 and Apple clang version 13.0.0 (clang-1300.0.29.3).

@stevengj
Copy link
Collaborator Author

stevengj commented Dec 7, 2021

Seems to be due to #1839, cc @kkg4theweb.

The issue is that this is a C++14 feature, I guess.

@stevengj stevengj added the bug label Dec 7, 2021
@stevengj
Copy link
Collaborator Author

stevengj commented Dec 7, 2021

Seems like it should be fine to replace this with an explicit unique_ptr, which is slightly more verbose but is otherwise equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant