Restructure connections
#1721
Merged
Restructure connections
#1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace `connections` with separate maps for incoming and outgoing connections. * Maintain separate connections for each chunk pair. These changes unblock some of the improvements disucssed on NanoComp#1710 and NanoComp#1670.
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
===========================================
- Coverage 73.35% 54.15% -19.20%
===========================================
Files 13 13
Lines 4530 4535 +5
===========================================
- Hits 3323 2456 -867
- Misses 1207 2079 +872
|
|
More immediate processing of incoming data illustrated here: |
oskooi
approved these changes
Aug 10, 2021
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* Replace `connections` with separate maps for incoming and outgoing connections. * Maintain separate connections for each chunk pair. These changes unblock some of the improvements disucssed on NanoComp#1710 and NanoComp#1670. Co-authored-by: Andreas Hoenselaar <[email protected]>
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
* Replace `connections` with separate maps for incoming and outgoing connections. * Maintain separate connections for each chunk pair. These changes unblock some of the improvements disucssed on NanoComp#1710 and NanoComp#1670. Co-authored-by: Andreas Hoenselaar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectionswith separate maps for incoming and outgoing connections.These changes unblock some of the improvements discussed on #1710 and #1670, in particular overlapped processing of incoming data.