create and delete temporary directory using unittest methods #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Feb 25, 2020
python/tests/chunks.py
Outdated
| def tearDown(self): | ||
| mp.all_wait() | ||
| if mp.am_master(): | ||
| shutil.rmtree(self.temp_dir,ignore_errors=True) |
There was a problem hiding this comment.
Can just do mp.delete_directory(self.temp_dir) now
oskooi
force-pushed
the
setup_teardown_python_tmpdir
branch
from
2ec78de
to
4de4ba4
Compare
stevengj
reviewed
Feb 25, 2020
|
This is ready to be merged. Afterwards, it would be good to do a 1.13.1 tagged release. |
|
Merged and tagged. |
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
…p#1132) * create and delete temporary directory inside unittest methods * fixes * put meep.all_wait before rmtree to prevent race condition * put all_wait before delete_directory in h5test to prevent race condition * replace shutil.rmtree with meep.delete_directory * replace setUp/tearDown with setUpClass/tearDownClass * decorate setUpClass/tearDownClass with classmethod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1121 involved creating and deleting a temporary directory directly within the
__main__function. However, certain interpreters have script scope enforcement and do not allow thetemp_dirdirectory name to be used outside of the__main__function leading to an error. Also, on certain systems,os.removedirscannot delete non-empty directories and aborts with an error.This PR moves the creation of the temporary directory to within the
setUpClassmethod of theunittestmechanism and stores the directory name as a member of theclsobject. The directory deletion is moved to thetearDownClassmethod andos.removedirsis replaced withmeep.delete_output_directorywhich can force the deletion of a non-empty directory and has a built-inall_wait()to prevent race conditions.All the tests from #1121 have been updated with these changes.