Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename omega parameters to frequency #1131

Closed
oskooi opened this issue Feb 19, 2020 · 1 comment · Fixed by #1171
Closed

rename omega parameters to frequency #1131

oskooi opened this issue Feb 19, 2020 · 1 comment · Fixed by #1171

Comments

@oskooi
Copy link
Collaborator

oskooi commented Feb 19, 2020

#919 introduced an omega parameter for the frequency for various Python and C functions such as get_epsilon_point, get_array, output_epsilon, etc. Since omega does not refer to the angular frequency (which contains a 2π factor), it should be renamed to frequency. This is consistent with other Meep functions which have a frequency argument. However, to maintain backwards compatibility, omega should continue to be supported for those functions which currently have an omega parameter (but still removed from the documentation).

@stevengj
Copy link
Collaborator

stevengj commented Mar 4, 2020

(I think the only way to implement this is to support both arguments, and give a deprecation warning if omega is passed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants