From 84d9f4b6c29f7768a0ba98a751976307644a4da0 Mon Sep 17 00:00:00 2001 From: Khaliq Date: Wed, 26 Jul 2023 21:11:42 +0300 Subject: [PATCH] [gh-#847] delete syncs for config --- packages/shared/lib/services/config.service.ts | 4 ++-- .../shared/lib/services/sync/schedule.service.ts | 12 ------------ 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/packages/shared/lib/services/config.service.ts b/packages/shared/lib/services/config.service.ts index a6daeaf91d..a7ae6e8469 100644 --- a/packages/shared/lib/services/config.service.ts +++ b/packages/shared/lib/services/config.service.ts @@ -7,7 +7,7 @@ import path from 'path'; import { isCloud, dirname } from '../utils/utils.js'; import { NangoError } from '../utils/error.js'; import encryptionManager from '../utils/encryption.manager.js'; -import { deleteScheduleForProviderConfig as deleteSyncScheduleForProviderConfig } from '../services/sync/schedule.service.js'; +import syncOrchestrator from './sync/orchestrator.service.js'; import { deleteSyncFilesForConfig, deleteByConfigId as deleteSyncConfigByConfigId } from '../services/sync/config.service.js'; class ConfigService { @@ -130,7 +130,7 @@ class ConfigService { throw new NangoError('unknown_provider_config'); } - await deleteSyncScheduleForProviderConfig(environment_id, providerConfigKey); + await syncOrchestrator.deleteSyncsByProviderConfig(environment_id, providerConfigKey); if (isCloud()) { const config = await this.getProviderConfig(providerConfigKey, environment_id); diff --git a/packages/shared/lib/services/sync/schedule.service.ts b/packages/shared/lib/services/sync/schedule.service.ts index 70448e47ee..93a1030ae1 100644 --- a/packages/shared/lib/services/sync/schedule.service.ts +++ b/packages/shared/lib/services/sync/schedule.service.ts @@ -48,18 +48,6 @@ export const deleteScheduleForSync = async (sync_id: string): Promise => { } }; -export const deleteScheduleForProviderConfig = async (environmentId: number, providerConfigKey: string): Promise => { - const syncs = await getSyncsByProviderConfigKey(environmentId, providerConfigKey); - - if (!syncs) { - return; - } - - for (const sync of syncs) { - await deleteScheduleForSync(sync.id as string); - } -}; - export const markAllAsStopped = async (): Promise => { await schema().update({ status: ScheduleStatus.STOPPED }).from(TABLE); };