Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Claims identity #1821

Closed
wants to merge 6 commits into from
Closed

Conversation

felipeleusin
Copy link
Contributor

This is a work in progress to help with issue #1800 .

My goal was to get the solution building and tests passing but there are two questions I need to know.

  1. Should the concept of UserName in Nancy be converted to a claim of type Name? In IUserIdentity the concept of being Authorized is usually associate with a not empty UserName but a ClaimsIdentity has a IsAuthenticated property that makes a lot of sense to use it.

  2. The Authentication.Token uses an specific spec for the tokens? If not, would be the case to switch to Jwt in v2 since they are somewhat Claims-friendly or it's better to adapt the current spec?

There is still a lot to do but I hope this can help with the grunt of the work

@khellang
Copy link
Member

Umm... I think there's some double work going on with #1820... 😞

@damianh
Copy link
Member

damianh commented Feb 20, 2015

Well shit. I probably should have assigned #1800 to myself before working on it. :S

@felipeleusin
Copy link
Contributor Author

no sweat. Since I saw nothing on #1800 I assumed it was still up for
grabs. Gonna close this then

Em sex, 20 de fev de 2015 07:52, Damian Hickey [email protected]
escreveu:

Well shit. I probably have assigned #1820
#1820 to myself before working on
it. :S


Reply to this email directly or view it on GitHub
#1821 (comment).

@damianh
Copy link
Member

damianh commented Feb 20, 2015

Really sorry @felipeleusin , appreciate the effort.

@felipeleusin
Copy link
Contributor Author

Relly don't worry... this didn't took much time and I got to learn about ClaimsPrincipal and similars that was a subject I could learn more. Was just hoping to contribute to Nancy since we use it extensively in my company but never had sent a PR. If there is anything else you guys need help with, let me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants