This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to help with issue #1800 .
My goal was to get the solution building and tests passing but there are two questions I need to know.
Should the concept of UserName in Nancy be converted to a claim of type Name? In IUserIdentity the concept of being Authorized is usually associate with a not empty UserName but a ClaimsIdentity has a IsAuthenticated property that makes a lot of sense to use it.
The Authentication.Token uses an specific spec for the tokens? If not, would be the case to switch to Jwt in v2 since they are somewhat Claims-friendly or it's better to adapt the current spec?
There is still a lot to do but I hope this can help with the grunt of the work