Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to GraphQL API #94

Closed
Namchee opened this issue Oct 21, 2023 · 2 comments · Fixed by #96
Closed

chore: migrate to GraphQL API #94

Namchee opened this issue Oct 21, 2023 · 2 comments · Fixed by #96
Assignees
@Namchee
Labels
enhancement New feature or request

Comments

@Namchee
Copy link
Owner

Namchee commented Oct 21, 2023

Overview

Currently, this project uses GitHub REST API v3 to interact with GitHub data such as issues, pull requests, etc. However, the REST API is proven to be insufficient which can be seen in #93.

To address this issue. GitHub itself recommends us to migrate to GraphQL.

Solutuon

Migrate all data fetching logic to GitHub GraphQL API v4. We can use this library to replace the v3 library.
@Namchee Namchee added the enhancement New feature or request label Oct 21, 2023
@Namchee Namchee self-assigned this Oct 21, 2023
@Namchee Namchee mentioned this issue Oct 22, 2023
Merged
@Namchee
Copy link
Owner Author

Namchee commented Oct 28, 2023

After some thoughts, I think we only need to migrate GetIssueReferences method to GraphQL.

@Namchee Namchee linked a pull request Oct 29, 2023 that will close this issue
docs: add Th3S4mur41 as a contributor for bug #92
Merged
@Namchee Namchee removed a link to a pull request Oct 29, 2023
docs: add Th3S4mur41 as a contributor for bug #92
Merged
@Namchee
Copy link
Owner Author

Namchee commented Oct 29, 2023

GetComments isn't migrated yet since the cursor implementation doesn't accept an empty string.

@Namchee Namchee mentioned this issue Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Namchee Namchee

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: migrate to graphql API when possible Namchee/conventional-pr
1 participant
@Namchee