Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the share functionality #253

Open
ceciliabjork opened this issue Feb 7, 2023 · 6 comments · Fixed by #288
Open

Upgrade the share functionality #253

ceciliabjork opened this issue Feb 7, 2023 · 6 comments · Fixed by #288
Assignees
Labels
1 priority 1 must be ready for next presentation

Comments

@ceciliabjork
Copy link

No description provided.

@saxjax saxjax added this to the Milestone April 2023 milestone Mar 15, 2023
@saxjax
Copy link
Collaborator

saxjax commented Mar 23, 2023

Remove the save new setup button, make sure that the setup is saved when share button is clicked

@saxjax saxjax added the 1 priority 1 must be ready for next presentation label Mar 23, 2023
@saxjax
Copy link
Collaborator

saxjax commented Mar 25, 2023

Before removing consider this:
A user sets up some setting.
then user clicks share this setup.
discovers that there is an error in the setup.
makes changes to the setup.
then clicks share this setup again.
What sould happen?

  1. User is presnted with a new link to astorred version of the recently created changes. Previous link is gone.
  2. User is presented with link to currently stored setup, a button lets user generate a new link to store the recent changes on.

I think the propper way to do this is to change the wording of the button to "save current settings on new url"

@ceciliabjork
Copy link
Author

ceciliabjork commented Apr 24, 2023

@saxjax @MartinBruun @granfors Usually the Share icon leads to more options, and I believe that was what Muriel had in mind. At the moment, I think a single function (copy) would be the least confusing. Just the link and the text "Copy link" at the moment. (And it would be great to have buttons for other Share functions later! See example from Twitter below...) Yes, the user would have to keep a manual record of iterations, but at the moment, I would be more inclined to go for as simple and immediately understandable as possible.

IMG_8116

@saxjax saxjax linked a pull request Apr 25, 2023 that will close this issue
@MartinBruun
Copy link
Collaborator

So far fixed by:
#288

@ceciliabjork ceciliabjork reopened this Apr 25, 2023
@ceciliabjork
Copy link
Author

@MartinBruun @saxjax It is still not at all clear to me what the "store online" means... Would it be possible to make this super simple and super clear just for the presentation? Just a "Copy link"? If someone asked me what the current configuration is for and how the different tabs works, I wouldn't be able to answer.

@MartinBruun
Copy link
Collaborator

@ceciliabjork Ahh yes I see what you mean, i closed it too quickly.
Will change it Tommorow morning. For some reason I overlooked that.

@saxjax saxjax changed the title What is the "Save this setup" in the Share this setup function? Upgrade the share functionality Apr 27, 2023
@saxjax saxjax removed this from the Milestone 27th of April 2023 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 priority 1 must be ready for next presentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants