Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logout Redirect #280

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Add Logout Redirect #280

merged 2 commits into from
Aug 9, 2023

Conversation

the-codetrane
Copy link
Contributor

@the-codetrane the-codetrane commented Aug 9, 2023 •
edited
Loading

Problem

When users log out, they get redirected to an OAuth landing page, which is jarring.

Solution

Add a redirect to the root_path to keep eyeballs on the app

QA Environment

https://geo-stage.library.nyu.edu/

PR Type

  • Feature
  • Tests
  • Janitorial (refactoring, dependency updates, etc.)

@the-codetrane the-codetrane force-pushed the mcain/add-logout-redirect branch from 1049c5b to a9a9b17 Compare August 9, 2023 14:13
@mnyrop mnyrop self-requested a review August 9, 2023 15:59
@the-codetrane the-codetrane merged commit c94e709 into main Aug 9, 2023
@the-codetrane the-codetrane deleted the mcain/add-logout-redirect branch August 9, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnyrop mnyrop mnyrop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-codetrane @mnyrop