Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spark.sql.parquet.datetimeRebaseModeInRead=LEGACY and spark.sql.parquet.int96RebaseModeInRead=LEGACY [databricks] #9649

Merged
merged 62 commits into from
Nov 15, 2023

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented Nov 6, 2023

This adds support for LEGACY mode in spark.sql.parquet.datetimeRebaseModeInRead and spark.sql.parquet.int96RebaseModeInRead, which allows reading files containing ancient dates/times before 1582-10-15 with rebasing from Julian calendar dates/times to Proleptic Gregorian calendar dates/times.

Closes:

Depends on:

ttnghia and others added 30 commits November 2, 2023 10:52
Signed-off-by: Nghia Truong <[email protected]>
# Conflicts:
#	sql-plugin/src/main/scala/com/nvidia/spark/RebaseHelper.scala
#	sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
…IA#9617)"

This reverts commit 401d0d8.

Signed-off-by: Nghia Truong <[email protected]>

# Conflicts:
#	sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
# Conflicts:
#	sql-plugin/src/main/scala/com/nvidia/spark/RebaseHelper.scala
#	sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuParquetScan.scala
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia ttnghia changed the title Support spark.sql.parquet.datetimeRebaseModeInRead=LEGACY [databricks] Support spark.sql.parquet.datetimeRebaseModeInRead=LEGACY and spark.sql.parquet.int96RebaseModeInRead=LEGACY [databricks] Nov 7, 2023
@ttnghia
Copy link
Collaborator Author

ttnghia commented Nov 10, 2023

build

1 similar comment
@ttnghia
Copy link
Collaborator Author

ttnghia commented Nov 10, 2023

build

@ttnghia ttnghia linked an issue Nov 14, 2023 that may be closed by this pull request
@ttnghia
Copy link
Collaborator Author

ttnghia commented Nov 14, 2023

build

@ttnghia ttnghia requested a review from revans2 November 14, 2023 23:44
@ttnghia
Copy link
Collaborator Author

ttnghia commented Nov 15, 2023

build

@revans2 revans2 merged commit c1c4708 into NVIDIA:branch-23.12 Nov 15, 2023
37 checks passed
@ttnghia ttnghia deleted the rebase_datatime branch November 15, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support spark.sql.parquet.datetimeRebaseModeInRead=LEGACY
2 participants