Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc]update download docs for 2308 version[skip ci] #8948

Merged
merged 6 commits into from
Aug 10, 2023
Merged

[Doc]update download docs for 2308 version[skip ci] #8948

merged 6 commits into from
Aug 10, 2023

Conversation

SurajAralihalli
Copy link
Collaborator

@SurajAralihalli SurajAralihalli commented Aug 7, 2023 •
edited
Loading

indexed from branch-23.08

  1. Updates download docs for 23.08 release
  2. Updates other markdown files to reflect 23.08 version
  3. Addresses issues #8701
  4. Unifies software requirements, hard requirements, prerequisites to reflect the same section in download.md across all the readme files to prevent duplication.

signed-off-by: SurajAralihalli [email protected]

@SurajAralihalli SurajAralihalli changed the base branch from branch-23.10 to branch-23.08 August 7, 2023 21:48
@viadea viadea requested review from sameerz, jlowe and mattf August 7, 2023 23:11
@viadea
Copy link
Collaborator

viadea commented Aug 7, 2023

@mattf @jlowe Could you help take a look at the release notes of 23.08 to see if you want to change or update it?thx

viadea
viadea requested changes Aug 7, 2023
View reviewed changes
docs/download.md Outdated Show resolved Hide resolved
jlowe
jlowe reviewed Aug 8, 2023
View reviewed changes
docs/download.md Outdated Show resolved Hide resolved
docs/download.md Outdated Show resolved Hide resolved
sameerz
sameerz reviewed Aug 8, 2023
View reviewed changes
docs/download.md Outdated Show resolved Hide resolved
@SurajAralihalli SurajAralihalli marked this pull request as ready for review August 8, 2023 19:50
@sameerz sameerz added the documentation Improvements or additions to documentation label Aug 9, 2023
nvliyuan
nvliyuan reviewed Aug 9, 2023
View reviewed changes
docs/download.md Outdated Show resolved Hide resolved
@SurajAralihalli
updated release notes
d9ff218 
Signed-off-by: Suraj Aralihalli <[email protected]>
viadea
viadea reviewed Aug 9, 2023
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
viadea
viadea reviewed Aug 9, 2023
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
viadea
viadea requested changes Aug 9, 2023
View reviewed changes
docs/get-started/getting-started-gcp.md Outdated Show resolved Hide resolved
docs/get-started/getting-started-on-prem.md Outdated Show resolved Hide resolved
@viadea viadea self-requested a review August 9, 2023 23:46
@nvliyuan nvliyuan self-requested a review August 10, 2023 04:05
@nvliyuan
Copy link
Collaborator

LGTM

@razajafri
Copy link
Collaborator

build

1 similar comment
@razajafri
Copy link
Collaborator

build

@viadea viadea merged commit e1a6508 into NVIDIA:branch-23.08 Aug 10, 2023
26 of 27 checks passed
@viadea viadea mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NvTimLiu NvTimLiu NvTimLiu left review comments

@sameerz sameerz sameerz left review comments

@mattahrens mattahrens mattahrens left review comments

@viadea viadea viadea approved these changes

@jlowe jlowe jlowe approved these changes

@mattf mattf Awaiting requested review from mattf

@nvliyuan nvliyuan Awaiting requested review from nvliyuan

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SurajAralihalli @viadea @nvliyuan @razajafri @jlowe @mattahrens @sameerz @NvTimLiu