Databricks shim version for integration test [databricks] #8917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Liu <[email protected]>
NvTimLiu
changed the title
|
build |
NvTimLiu
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
zhanga5
as code owners
jlowe
approved these changes
Aug 3, 2023
tgravescs
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #8828
To fix: #8923
Move SPARK_SHIM_VER into share Databricks script file.
Need to set SPARK_SHIM_VER=
spark3xxdbto run integration tests againstspark3xxdbintegration test jar, otherwise some test cases would failed as below due to referring tospark3xx.jarintegration test jarmortgage_test.py::test_mortgage[IGNORE_ORDER, INCOMPAT, APPROXIMATE_FLOAT, ALLOW_NON_GPU(ANY), LIMIT(100000)] - TypeError: 'JavaPackage' object is not callable