-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support casting Decimal to String #2046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <[email protected]>
build |
revans2
reviewed
Mar 30, 2021
Signed-off-by: sperlingxx <[email protected]>
build |
build |
build |
revans2
reviewed
Mar 31, 2021
tests/src/test/scala/com/nvidia/spark/rapids/GpuExpressionTestSuite.scala
Show resolved
Hide resolved
Merged
build |
Signed-off-by: sperlingxx <[email protected]>
build |
build |
build |
I think this PR is ready to merge. |
jlowe
approved these changes
Apr 5, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* support casting decimal to string Signed-off-by: sperlingxx <[email protected]> * update CastChecks Signed-off-by: sperlingxx <[email protected]> * sync to latest main * add RapidsConfig isCastDecimalToStringEnabled * fix Signed-off-by: sperlingxx <[email protected]> * update configs.md
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* support casting decimal to string Signed-off-by: sperlingxx <[email protected]> * update CastChecks Signed-off-by: sperlingxx <[email protected]> * sync to latest main * add RapidsConfig isCastDecimalToStringEnabled * fix Signed-off-by: sperlingxx <[email protected]> * update configs.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sperlingxx [email protected]
Current PR is to support casting Decimal to String, which is requested in issue #1625.