Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Improve CSV integration tests for parsing dates and timestamps #9990

Open
andygrove opened this issue Dec 7, 2023 · 0 comments
Open

[FEA] Improve CSV integration tests for parsing dates and timestamps #9990

andygrove opened this issue Dec 7, 2023 · 0 comments
Labels
test Only impacts tests

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There are some significant limitations in our CSV integration tests with respect to parsing dates and timestamps.

  • We only test with explicitly setting dateFormat and do not test the case where we do not specify a dateFormat
  • We only test by round-tripping with valid dates. We are not testing with generated string data containing a mix of valid and invalid dates.

Describe the solution you'd like
See #9975 where the JSON tests were improved. We should be able to apply similar changes to the CSV tests.

Describe alternatives you've considered

Additional context
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 7, 2023
@andygrove andygrove mentioned this issue Dec 7, 2023
Merged
5 tasks
@mattahrens mattahrens added test Only impacts tests and removed feature request New feature or request labels Dec 12, 2023
@mattahrens mattahrens mentioned this issue Dec 12, 2023
Open
38 tasks
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andygrove @mattahrens