Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildall and doc to generate bloop projects for test debugging #9547

Closed
gerashegalov opened this issue Oct 25, 2023 · 6 comments
Closed
Assignees
Labels
bug Something isn't working build Related to CI / CD or cleanly building

Comments

@gerashegalov
Copy link
Collaborator

gerashegalov commented Oct 25, 2023

  • Require JDK11+ in doc and buildall for creating bloop projects
  • make sure all sub-modules are included
  • figure out why product classes when debugging a tests class are shown "unknown source" while Spark dependencies retrieved with -DdownloadSources are fine.

h/t: originally reported by @PhilDakin

Originally posted by @gerashegalov in #9542 (comment)

@gerashegalov gerashegalov added ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building bug Something isn't working labels Oct 25, 2023
@PhilDakin
Copy link
Contributor

@gerashegalov depending on expected turnaround time, I'd be keen to take this on as a first contribution.

At the latest I would open a PR by 11/2.

@gerashegalov
Copy link
Collaborator Author

Thank you @PhilDakin, go for it!

@gerashegalov gerashegalov added Scala 2.13 Issues related to Scala 2.13 binaries and removed Scala 2.13 Issues related to Scala 2.13 binaries labels Oct 31, 2023
@gerashegalov
Copy link
Collaborator Author

related to #9556

@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Oct 31, 2023
@PhilDakin
Copy link
Contributor

buildall/doc changes are easy. Still looking into the "Unknown Sources" issue. See corresponding issue on the Metals project: scalameta/metals#5807

@gerashegalov
Copy link
Collaborator Author

buildall/doc changes are easy. Still looking into the "Unknown Sources" issue. See corresponding issue on the Metals project: scalameta/metals#5807

Thanks for bringing up the issue with the scalameta team. We can handle this in issues and PRs separate from "simple" changes to the build and documentation.

@gerashegalov
Copy link
Collaborator Author

This is fixed by #9615,

"Unknown source" is filed scalameta/metals#5807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Development

No branches or pull requests

3 participants