Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Leaks and Double Frees in Unit Tests #9261

Closed
revans2 opened this issue Sep 19, 2023 · 0 comments · Fixed by #9264
Closed

[BUG] Leaks and Double Frees in Unit Tests #9261

revans2 opened this issue Sep 19, 2023 · 0 comments · Fixed by #9264
Assignees
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Sep 19, 2023

Describe the bug
I recently ran the unit tests on my desktop and noticed that there were a few leaks and double frees happening.

  • One of the leaks appears to be in the RapidsDiskStore and is fixed by Have host spill use the new HostAlloc API #9257
  • Another is from GpuColumnarToRowExec, and appears to be that the unit test didn't drain all of the data and because there is no task context the task completion code didn't run to clean it up.
  • The final one is a double free that is happening in GpuCoalesceBatchesSuite.scala:751 which is called from line 674 and is a part of test("test entering filtering mode with not enough nulls"). It looks like the test is expecting an exception to be thrown and it is probably a bug in our exception handling that needs to be looked into.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 19, 2023
@revans2 revans2 self-assigned this Sep 19, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants