Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Configuring GDS breaks new host spillable buffers and batches #9106

Closed
abellina opened this issue Aug 24, 2023 · 1 comment · Fixed by #9270
Closed

[BUG] Configuring GDS breaks new host spillable buffers and batches #9106

abellina opened this issue Aug 24, 2023 · 1 comment · Fixed by #9270
Assignees
Labels
bug Something isn't working

Comments

@abellina
Copy link
Collaborator

As it is, #8882 has added a scenario that breaks when GDS is configured. Currently GDS is disabled by default and we are not aware of anyone using it, but I am filing this to document that GDS will break in 23.10 unless we make some changes.

The least amount of change would be to have two "paths" for spilling buffers. Buffers/batches added to the device store could go to GDS, but if GDS is enabled a RapidsHostMemoryStore and a RapidsDiskStore would also be enabled and it would be available for host buffers and host batches. These "host originated" RapidsBuffer instances would only be able to go between host and disk, whereas the "device originated" RapidsBuffer instances would be allowed to go from RapidsDeviceMemoryStore to RapidsGDSStore, bypassing host memory/disk stores.

@abellina abellina added bug Something isn't working ? - Needs Triage Need team to review and classify labels Aug 24, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Sep 6, 2023
@mattahrens
Copy link
Collaborator

Removing GDS support in the plugin is the next step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants