Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUDIT][SPARK-32614][SQL] Don't apply comment processing if 'comment' unset for CSV #8205

Open
abellina opened this issue Apr 28, 2023 · 1 comment
Labels
audit_3.5.0 bug Something isn't working

Comments

@abellina
Copy link
Collaborator

This was an audit for Spark 3.5 apache/spark#29516 where the CSV parser was changed to not consider lines that start with a null character as comments.

Likely this falls under the corner case category, but something we should at least investigate.

@abellina abellina added bug Something isn't working ? - Needs Triage Need team to review and classify audit_3.5.0 labels Apr 28, 2023
@revans2
Copy link
Collaborator

revans2 commented May 1, 2023

Yes this is probably a corner case, but we use the "null" character to turn off comments in CUDF. So it might be more relevant than we think. At least we should test it and document any differences.

@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit_3.5.0 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants