Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Round robin partitioning sort check falls back to CPU for cases that can be supported #7807

Closed
jlowe opened this issue Feb 23, 2023 · 2 comments · Fixed by #9067
Closed
Assignees
Labels
bug Something isn't working

Comments

@jlowe
Copy link
Member

jlowe commented Feb 23, 2023

In GpuShuffleExchangeExecBase, tagPlanForGpu checks if the partitioning is round-robin and sort before repartition is enabled. If so, it then checks whether the types are orderable by the GPU. There's a GpuOverrides.pluginSupportedOrderableSig value that should be everything we support sorting on, but it's missing decimal128 and structs. Most places are manually tacking these on, but this is one that missed structs.

Ideally we should cleanup pluginSupportedOrderableSig to be everything we support sorting on, and add tests for repartitioning-with-sorting for struct types that are GPU orderable.

@jlowe jlowe added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 23, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 28, 2023
@ttnghia
Copy link
Collaborator

ttnghia commented Mar 10, 2023

@jlowe
Copy link
Member Author

jlowe commented Mar 17, 2023

This does not depend on the cudf issue. This is a bug in the type check logic in the plugin where what is already supported by cudf, even before the mentioned cudf issue, is not always used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants