You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In GpuShuffleExchangeExecBase, tagPlanForGpu checks if the partitioning is round-robin and sort before repartition is enabled. If so, it then checks whether the types are orderable by the GPU. There's a GpuOverrides.pluginSupportedOrderableSig value that should be everything we support sorting on, but it's missing decimal128 and structs. Most places are manually tacking these on, but this is one that missed structs.
Ideally we should cleanup pluginSupportedOrderableSig to be everything we support sorting on, and add tests for repartitioning-with-sorting for struct types that are GPU orderable.
The text was updated successfully, but these errors were encountered:
This does not depend on the cudf issue. This is a bug in the type check logic in the plugin where what is already supported by cudf, even before the mentioned cudf issue, is not always used.
In GpuShuffleExchangeExecBase,
tagPlanForGpu
checks if the partitioning is round-robin and sort before repartition is enabled. If so, it then checks whether the types are orderable by the GPU. There's aGpuOverrides.pluginSupportedOrderableSig
value that should be everything we support sorting on, but it's missing decimal128 and structs. Most places are manually tacking these on, but this is one that missed structs.Ideally we should cleanup
pluginSupportedOrderableSig
to be everything we support sorting on, and add tests for repartitioning-with-sorting for struct types that are GPU orderable.The text was updated successfully, but these errors were encountered: