Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]JSON reader: support comments #4610

Open
Tracked by #9
GaryShen2008 opened this issue Jan 24, 2022 · 1 comment
Open
Tracked by #9

[FEA]JSON reader: support comments #4610

GaryShen2008 opened this issue Jan 24, 2022 · 1 comment
Labels
task Work required that improves the product but is not user facing

Comments

@GaryShen2008
Copy link
Collaborator

From Spark JSON options,
there's one option "allowComments" to ignores Java/C++ style comment in JSON records.
We should consider to support that, otherwise it should fallback to CPU running.

Let's see if cuDF can do that, or we can filter out the comments before calling cuDF API.
@GaryShen2008 GaryShen2008 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 24, 2022
@GaryShen2008 GaryShen2008 mentioned this issue Jan 24, 2022
Open
62 tasks
@sameerz sameerz added task Work required that improves the product but is not user facing and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 25, 2022
@wbo4958
Copy link
Collaborator

wbo4958 commented Feb 10, 2022

Filed a CUDF issue for the feature, rapidsai/cudf#10265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wbo4958 @sameerz @GaryShen2008