Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded Shim functions #4304

Closed
tgravescs opened this issue Dec 6, 2021 · 1 comment
Closed

Remove unneeded Shim functions #4304

tgravescs opened this issue Dec 6, 2021 · 1 comment
Labels
build Related to CI / CD or cleanly building duplicate This issue or pull request already exists task Work required that improves the product but is not user facing

Comments

@tgravescs
Copy link
Collaborator

tgravescs commented Dec 6, 2021

Is your feature request related to a problem? Please describe.
in SparkShims there are now a bunch of functions that aren't needed because they were there just to build in the old shims module to make sure the Type matched the Spark version, or to do some work on a type that was specific and then return a type that was common.

For instance there are: getPartitionedFiles, replacePartitionDirectoryFiles , getPartition* functions that were there just to build against the particular Spark version but then returned a type that was not changed in any Spark version. These can now just be removed from the shim because we build the code against each version.

getArrowValidityBuf, getArrowDataBuf, getArrowOffsetsBuf may also be one as it was just picking up different Arrow versions
replaceWithAlluxioPathIfNeeded should be checked as I think again it was manipulating things specific to the spark version in side of it.
others possibly: registerKryoClasses

@tgravescs tgravescs added ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building task Work required that improves the product but is not user facing labels Dec 6, 2021
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Dec 7, 2021
@jlowe jlowe added the duplicate This issue or pull request already exists label Mar 24, 2022
@jlowe
Copy link
Member

jlowe commented Mar 24, 2022

Covered by #5005.

@jlowe jlowe closed this as completed Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building duplicate This issue or pull request already exists task Work required that improves the product but is not user facing
Projects
None yet
Development

No branches or pull requests

3 participants