Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support rank as window function #1584

Closed
sperlingxx opened this issue Jan 26, 2021 · 2 comments · Fixed by #2953
Closed

[FEA] Support rank as window function #1584

sperlingxx opened this issue Jan 26, 2021 · 2 comments · Fixed by #2953
Assignees
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@sperlingxx
Copy link
Collaborator

sperlingxx commented Jan 26, 2021

Is your feature request related to a problem? Please describe.
rank is a frequently used window function within SQL context, same as: row_number or count. Spark catalyst supports rank as window function, but spark-rapids hasn't provided GPU overriding of rank.

Describe the solution you'd like
Like row_number or other window functions, GPU overriding of rank should be relied on cuDF rolling window aggregation. However, cuDF has yet supported rank as a kind of aggregation. So, we need to support rank in cuDF in primary. Referring the implementation of row_number, we only needs to implement process_rolling_window function for rank if we don't support rank with time_range_rolling_window (which could be done in future).

@sperlingxx sperlingxx added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 26, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 26, 2021
@sameerz sameerz added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Feb 12, 2021
@sameerz
Copy link
Collaborator

sameerz commented May 11, 2021

Depends on rapidsai/cudf#8138 , rapidsai/cudf#8158

@sameerz
Copy link
Collaborator

sameerz commented Jul 20, 2021

Depends on rapidsai/cudf#8652

@revans2 revans2 linked a pull request Jul 26, 2021 that will close this issue
@revans2 revans2 added this to the July 19 - July 30 milestone Jul 26, 2021
@revans2 revans2 closed this as completed Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants