Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOLLOWUP] Query max instructions length in getJsonObject from JNI #10646

Closed
thirtiseven opened this issue Apr 1, 2024 · 4 comments · Fixed by #10800
Closed

[FOLLOWUP] Query max instructions length in getJsonObject from JNI #10646

thirtiseven opened this issue Apr 1, 2024 · 4 comments · Fixed by #10800
Assignees

Comments

@thirtiseven
Copy link
Collaborator

          Nit: The max length value should be queried from JNI so we always have such value sync. This can be addressed in the follow up work (which requires JNI to expose such value).

Originally posted by @ttnghia in #10581 (comment)

Also some test cases need to clean up, see #10581 's comments.

@thirtiseven thirtiseven self-assigned this Apr 1, 2024
@thirtiseven thirtiseven changed the title [FOLLOWUP] Queried max instructions length in getJsonObject from JNI [FOLLOWUP] Query max instructions length in getJsonObject from JNI Apr 1, 2024
@thirtiseven
Copy link
Collaborator Author

Another follow-up: get_json_object compatibility doc is outdated.

https://github.com/NVIDIA/spark-rapids/blob/branch-24.04/docs/compatibility.md#get_json_object

@thirtiseven
Copy link
Collaborator Author

float normalization will have some compatibility issue, as the same as float to string. We should add another test to verify it.

@sameerz
Copy link
Collaborator

sameerz commented May 13, 2024

Another follow-up: get_json_object compatibility doc is outdated.

https://github.com/NVIDIA/spark-rapids/blob/branch-24.04/docs/compatibility.md#get_json_object

@thirtiseven I noticed the PR that closed this issue did not update the documentation. Are the docs still accurate?

@thirtiseven
Copy link
Collaborator Author

Another follow-up: get_json_object compatibility doc is outdated.
https://github.com/NVIDIA/spark-rapids/blob/branch-24.04/docs/compatibility.md#get_json_object

@thirtiseven I noticed the PR that closed this issue did not update the documentation. Are the docs still accurate?

Yes, it has been updated in f6054fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants