Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] JsonToStructs fails to parse all empty dicts and invalid lines #10483

Closed
revans2 opened this issue Feb 23, 2024 · 2 comments
Closed

[BUG] JsonToStructs fails to parse all empty dicts and invalid lines #10483

revans2 opened this issue Feb 23, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 23, 2024

Describe the bug
We know that there are some issues in CUDF with parsing empty lines. We first tried to fix this by passing in an empty dictionary as a place holder '{}' but this caused other problems because CUDF is not happy to produce a table with no columns in it. Or perhaps more accurately some of our code is not happy with that. We worked around this by adding in a column that was requested and setting it to null. That works for empty lines, but it shows up as a problem if all of the lines are {}, [], or all of them have something in them, but it is invalid.

We really should just fix the underlying problem instead of trying to work around it. This also exists in ScanJson, but I have not formally added a test for it yet.

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 23, 2024
@revans2 revans2 mentioned this issue Feb 26, 2024
62 tasks
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 27, 2024
@revans2
Copy link
Collaborator Author

revans2 commented Mar 14, 2024

Currently this is throwing a NullPointerException in CUDF on the java side. I think we can probably fix it without too much trouble.

@revans2
Copy link
Collaborator Author

revans2 commented Oct 18, 2024

This appears to have been fixed. All of the tests pass.

@revans2 revans2 closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants