Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] JsonToStructs should reject 1. as a valid number #10467

Closed
revans2 opened this issue Feb 22, 2024 · 0 comments · Fixed by #10542
Closed

[BUG] JsonToStructs should reject 1. as a valid number #10467

revans2 opened this issue Feb 22, 2024 · 0 comments · Fixed by #10542
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 22, 2024

Describe the bug
For some reason ScanJson does the right thing, but JsonToStructs/from_json interprets this as 1.0 instead of a failure that is null. I think this applies to all numbers formatted in a similar way. (with just a trailing .)

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 22, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants