Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] JsonToStructs and ScanJson do not fall back/support it properly if single quotes are disabled #10455

Closed
revans2 opened this issue Feb 21, 2024 · 1 comment · Fixed by #10490
Assignees
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 21, 2024

Describe the bug
Up until recently single quote support was not in JsonToStructs or ScanJson. It was recently enabled, but when the config is enabled it does not fall back to the CPU or disable the feature and do the right thing.

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 21, 2024
@revans2 revans2 changed the title [BUG] JsonToStructs does not fall back/support it properly if single quotes are disabled [BUG] JsonToStructs and ScanJson do not fall back/support it properly if single quotes are disabled Feb 21, 2024
@revans2 revans2 self-assigned this Feb 21, 2024
@revans2
Copy link
Collaborator Author

revans2 commented Feb 21, 2024

I am putting up a PR to fall back correctly when needed, but I tried to actually enable not supporting single quoted strings, but that would result in CUDF returning the full value as if it were a string.

{"str": 'World'}

resulted in 'World' being returned. This is even with mixed types as strings disabled.

@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants