Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update WindowExpression parser to handle truncated argument list #834

Closed
nartal1 opened this issue Mar 6, 2024 · 0 comments · Fixed by #890
Closed

[BUG] Update WindowExpression parser to handle truncated argument list #834

nartal1 opened this issue Mar 6, 2024 · 0 comments · Fixed by #890
Assignees
Labels
bug Something isn't working core_tools Scope the core module (scala)

Comments

@nartal1
Copy link
Collaborator

nartal1 commented Mar 6, 2024

Describe the bug
Some eventlogs do not have complete argument list for Window Exec.
For example:

Arguments: [arg1#26, arg2#29L, arg3#30, arg4#31L, arg5#32, arg6#33, arg7#34, arg8#47, arg9#48, arg10#49, arg11#50, arg12#51, arg13#76, ... 52 more fields], [col1#26], [time1#27L ASC NULLS FIRST]

Current WindowParser doesn't handle this case and ends up classifying WindowExec as not supported. For incomplete argumentlist, we should try to get the function names(if present). If there are no function names, then skip parsing that expression.

@nartal1 nartal1 added bug Something isn't working ? - Needs Triage core_tools Scope the core module (scala) labels Mar 6, 2024
@nartal1 nartal1 self-assigned this Mar 13, 2024
@amahussein amahussein changed the title [BUG] Update WindowExpression parser to handle truncated argument list. [BUG] Update WindowExpression parser to handle truncated argument list Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants