Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Improve usage and code flow of Heuristics + Filtering #1379

Open
parthosa opened this issue Oct 7, 2024 · 0 comments
Open

[BUG] Improve usage and code flow of Heuristics + Filtering #1379

parthosa opened this issue Oct 7, 2024 · 0 comments
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@parthosa
Copy link
Collaborator

parthosa commented Oct 7, 2024

Currently, it seems unclear what should be a Heuristic and what should be a TC Filter. Stating the purpose here. We should also add this in Docs.

Purpose:

  • Heuristics: Based on certain metrics, all apps that do not meet the criteria should be downgraded to Not Recommended
    • E.g. Spill Metrics
  • Top Candidate Filter: Based on certain metrics, all Recommended apps that do not meet the criteria should not be displayed on console.
    • E.g. Total Core Seconds

The problem is with the usage of unsupported operators. I find the its usage at a very odd place. I think we should move it to Heuristics module.

cc: @amahussein

@parthosa parthosa added ? - Needs Triage bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

No branches or pull requests

2 participants