-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding DoMINO example to Modulus #709
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktangsali
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment about the image, otherwise LGTM!
/blossom-ci |
Hi @RishikeshRanade , there are some linting issues. Can you take a look? you should be able to use precommit for this: https://github.com/NVIDIA/modulus/blob/main/CONTRIBUTING.md#pre-commit |
/blossom-ci |
ktangsali
added a commit
that referenced
this pull request
Nov 19, 2024
* Move cuda padding routines to healpix.py, check for cuda before attempting cuda install * Update the conf paths in docs (#712) * Fix for dlwp_healpix dataloader not including coupled variables (#702) Co-authored-by: David Pruitt <[email protected]> * Adding DoMINO example to Modulus (#709) --------- Co-authored-by: Kaustubh Tangsali <[email protected]> Co-authored-by: Kaustubh <[email protected]> --------- Co-authored-by: Kaustubh Tangsali <[email protected]> Co-authored-by: ivanauyeung <[email protected]> Co-authored-by: RishikeshRanade <[email protected]> Co-authored-by: Kaustubh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modulus Pull Request
Description
Checklist
Dependencies