Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DoMINO example to Modulus #709

Merged
merged 11 commits into from
Nov 18, 2024
Merged

Conversation

RishikeshRanade
Copy link
Collaborator

Modulus Pull Request

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

Copy link
Collaborator

@ktangsali ktangsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment about the image, otherwise LGTM!

examples/cfd/external_aerodynamics/domino/README.md Outdated Show resolved Hide resolved
@ktangsali
Copy link
Collaborator

/blossom-ci

@ktangsali
Copy link
Collaborator

Hi @RishikeshRanade , there are some linting issues. Can you take a look? you should be able to use precommit for this: https://github.com/NVIDIA/modulus/blob/main/CONTRIBUTING.md#pre-commit

@ktangsali
Copy link
Collaborator

/blossom-ci

@ktangsali ktangsali merged commit 9e96ddf into NVIDIA:main Nov 18, 2024
1 check passed
ktangsali added a commit that referenced this pull request Nov 19, 2024
* Move cuda padding routines to healpix.py, check for cuda before attempting cuda install

* Update the conf paths in docs (#712)

* Fix for dlwp_healpix dataloader not including coupled variables (#702)

Co-authored-by: David Pruitt <[email protected]>

* Adding DoMINO example to Modulus (#709)



---------

Co-authored-by: Kaustubh Tangsali <[email protected]>
Co-authored-by: Kaustubh <[email protected]>

---------

Co-authored-by: Kaustubh Tangsali <[email protected]>
Co-authored-by: ivanauyeung <[email protected]>
Co-authored-by: RishikeshRanade <[email protected]>
Co-authored-by: Kaustubh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants