Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ahmed body fixes #124

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Ahmed body fixes #124

merged 4 commits into from
Oct 13, 2023

Conversation

ktangsali
Copy link
Collaborator

Modulus Pull Request

Description

This fixes the ambiguity in the checkpoint directory naming and also fixes the model loading code in the inference script.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is
    up to date with these changes.

Dependencies

@ktangsali
Copy link
Collaborator Author

/blossom-ci

1 similar comment
@ktangsali
Copy link
Collaborator Author

/blossom-ci

@ktangsali ktangsali self-assigned this Oct 12, 2023
@ktangsali
Copy link
Collaborator Author

/blossom-ci

@loliverhennigh
Copy link
Collaborator

Looks good to me!

Copy link
Collaborator

@mnabian mnabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ktangsali ktangsali merged commit fd72a07 into NVIDIA:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants