Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable opt-out for bitwise comparable payload requirement #427

Open
sleeepyjack opened this issue Jan 22, 2024 · 0 comments
Open

Enable opt-out for bitwise comparable payload requirement #427

sleeepyjack opened this issue Jan 22, 2024 · 0 comments
Labels
P2: Nice to have Desired, but not necessary type: feature request New feature request

Comments

@sleeepyjack
Copy link
Collaborator

sleeepyjack commented Jan 22, 2024

Background

We currently require payload types to be bitwise comparable, which is required when we use the "packed CAS" insertion strategy.

Discussion from #426:

we could consider skipping the packed-CAS code path when is_bitwise_comparable_v(Key) && !is_bitwise_comparable_v(Value)

I'd rather keep performance-related settings as an opt-out rather than opt-in, i.e., we could add a global flag CUCO_REQUIRE_BITWISE_COMPARABLE_PAYLOADS which is on by default but can be turned off by the user.

This, of course, should be documented with an example.

Originally posted by @sleeepyjack in #426 (comment)

@PointKernel PointKernel added type: feature request New feature request P2: Nice to have Desired, but not necessary labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2: Nice to have Desired, but not necessary type: feature request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants