From f5a9f2566b23b04bec48d2fecefe2fe0958f9a07 Mon Sep 17 00:00:00 2001 From: John St John Date: Tue, 8 Oct 2024 15:49:18 +0000 Subject: [PATCH] Reference issue #275 --- .../bionemo-llm/src/bionemo/llm/model/biobert/model.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sub-packages/bionemo-llm/src/bionemo/llm/model/biobert/model.py b/sub-packages/bionemo-llm/src/bionemo/llm/model/biobert/model.py index 0133aa6f2d..c92a27c7ac 100644 --- a/sub-packages/bionemo-llm/src/bionemo/llm/model/biobert/model.py +++ b/sub-packages/bionemo-llm/src/bionemo/llm/model/biobert/model.py @@ -78,9 +78,12 @@ logger = logging.getLogger(__file__) # Add some fields specific to the BIOBERT config that we want to override by default +# TODO automatically determine which fields a user is trying to override in the future. _OVERRIDE_BIOBERT_CONFIG_DEFAULTS: List[str] = OVERRIDE_BIONEMO_CONFIG_DEFAULTS + [ "return_only_hidden_states", "include_hiddens", + # Model parallelism settings! Important to override these if the user requests different settings from how + # a model was trained (common). See https://github.com/NVIDIA/bionemo-fw-ea/issues/275 "tensor_model_parallel_size", "pipeline_model_parallel_size", "virtual_pipeline_model_parallel_size",