Skip to content

Commit

Permalink
feat(//.github): Moving to python directly
Browse files Browse the repository at this point in the history
Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>
  • Loading branch information
narendasan committed Nov 10, 2020
1 parent e72280a commit ece114c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/scripts/run_cpp_linter.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
pr = repo.get_pull(pr_number)
commit = repo.get_commit(pr.base.sha)

output = subprocess.run(["bazel", "run", "//tools/linter:cpplint_diff", "--", "--no-color", "//..."], stdout=subprocess.PIPE)
output = subprocess.run(["python3", "tools/linter/cpplint_diff.py", "--no-color", "//..."], stdout=subprocess.PIPE)

comment = '''Code conforms to C++ style guidelines'''
approval = 'APPROVE'
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/run_py_linter.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
pr = repo.get_pull(pr_number)
commit = repo.get_commit(pr.base.sha)

output = subprocess.run(["bazel", "run", "//tools/linter:pylint_diff", "--", "//..."], stdout=subprocess.PIPE)
output = subprocess.run(["python3", "tools/linter:pylint_diff", "//..."], stdout=subprocess.PIPE)

comment = '''Code conforms to Python style guidelines'''
approval = 'APPROVE'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,6 @@ jobs:
- name: Install dependencies
run: |
docker exec pylinter bash -c "pip3 install -r /workspace/.github/scripts/requirements.txt"
docker exec pylinter bash -c "pip3 install -r /workspace/tools/linter/requirements.txt"
- name: Lint Python
run: docker exec pylinter bash -c "cd /workspace && python3 /workspace/.github/scripts/run_cpp_linter.py"

0 comments on commit ece114c

Please sign in to comment.