feat(//.github): Linter throws 1 when there needs to be style changes to

show failing test to people whose PRs cant get linting inlined Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
pytorch · Apr 21, 2021 · a39dea7 · a39dea7
1 parent 59868d2
commit a39dea7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/.github/scripts/run_cpp_linter.py b/.github/scripts/run_cpp_linter.py
@@ -23,6 +23,7 @@
 if output.returncode != 0:
     comment = '''There are some changes that do not conform to C++ style guidelines:\n ```diff\n{}```'''.format(output.stdout.decode("utf-8"))
     approval = 'REQUEST_CHANGES'
+    exit(1)
 
 pr.create_review(commit, comment, approval)
 

diff --git a/.github/scripts/run_py_linter.py b/.github/scripts/run_py_linter.py
@@ -23,5 +23,6 @@
 if output.returncode != 0:
     comment = '''There are some changes that do not conform to Python style guidelines:\n ```diff\n{}```'''.format(output.stdout.decode("utf-8"))
     approval = 'REQUEST_CHANGES'
+    exit(1)
 
 pr.create_review(commit, comment, approval)