fix(Windows)!: Fix dependency resolution for local builds

BREAKING CHANGE: Users on Windows trying to use cuDNN 8 must manually configure third_party/cudnn/local/BUILD to use cuDNN 8. Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
pytorch · Jul 31, 2020 · 858d8c3 · xsacha · Jul 31, 2020 · 858d8c3
1 parent 83eb3ad
commit 858d8c3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/third_party/cudnn/local/BUILD b/third_party/cudnn/local/BUILD
@@ -26,7 +26,7 @@ cc_import(
     name = "cudnn_lib",
     shared_library = select({
         ":aarch64_linux": "lib/aarch64-linux-gnu/libcudnn.so",
-        ":windows": glob(["bin/cudnn64_*.dll"])[0],
+        ":windows": "bin/cudnn64_7.dll", #Need to configure specific version for windows
         "//conditions:default": "lib/x86_64-linux-gnu/libcudnn.so",
     }),
     visibility = ["//visibility:private"],

diff --git a/third_party/tensorrt/local/BUILD b/third_party/tensorrt/local/BUILD
@@ -72,7 +72,6 @@ cc_import(
 
 cc_library(
     name = "nvinfer",
-    srcs = select({ ":windows": [ "lib/nvinfer.lib" ] }),
     deps = [
         "nvinfer_headers",
         "nvinfer_lib",