Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterbankFeaturesTA imcompatible with FilterbankFeatures #5912

Closed
msis opened this issue Feb 3, 2023 · 1 comment · Fixed by #5913
Closed

FilterbankFeaturesTA imcompatible with FilterbankFeatures #5912

msis opened this issue Feb 3, 2023 · 1 comment · Fixed by #5913
Labels
bug Something isn't working

Comments

@msis
Copy link
Contributor

msis commented Feb 3, 2023

The new FilterbankFeaturesTA does not use the same naming convention as FilterbankFeatures.
This leads to errors when using the FilterbankFeaturesTA in a model.

For instance here:

dither_value = self.preprocessor.featurizer.dither
pad_to_value = self.preprocessor.featurizer.pad_to

While FilterbankFeatures defines those attributes, FilterbankFeaturesTA uses different naming:

self._dither_value = dither
self._pad_to = pad_to

@msis msis added the bug Something isn't working label Feb 3, 2023
@titu1994
Copy link
Collaborator

titu1994 commented Feb 3, 2023

Oh thank you for raising this, and also for the PR. Very nice catch. I'd ideally like to have a ci test for Torchaudio stuff, but until our containers include it as part of the Nvidia pytorch container it will be challenging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants