You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new FilterbankFeaturesTA does not use the same naming convention as FilterbankFeatures.
This leads to errors when using the FilterbankFeaturesTA in a model.
Oh thank you for raising this, and also for the PR. Very nice catch. I'd ideally like to have a ci test for Torchaudio stuff, but until our containers include it as part of the Nvidia pytorch container it will be challenging.
The new
FilterbankFeaturesTA
does not use the same naming convention asFilterbankFeatures
.This leads to errors when using the
FilterbankFeaturesTA
in a model.For instance here:
NeMo/nemo/collections/asr/models/ctc_models.py
Lines 160 to 161 in ddb92e3
While
FilterbankFeatures
defines those attributes,FilterbankFeaturesTA
uses different naming:NeMo/nemo/collections/asr/parts/preprocessing/features.py
Lines 540 to 541 in ddb92e3
The text was updated successfully, but these errors were encountered: