Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fastembed 0.4.1 broke our build, please lock it to 0.4.0 #820

Open
3 of 4 tasks
DixitAdh opened this issue Oct 23, 2024 · 1 comment
Open
3 of 4 tasks

bug: fastembed 0.4.1 broke our build, please lock it to 0.4.0 #820

DixitAdh opened this issue Oct 23, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@DixitAdh
Copy link

Did you check docs and existing issues?

  • I have read all the NeMo-Guardrails docs
  • I have updated the package to the latest version before submitting this issue
  • (optional) I have used the develop branch
  • I have searched the existing issues of NeMo-Guardrails

Python version (python --version)

Python 3.10.12

Operating system/version

Databricks model serving

NeMo-Guardrails version (if you must use a specific version and not the latest

0.10.0

Describe the bug

I noticed you are using fastembed>=0.2.2 dependency, they have recently release a new version 0.4.1 in which they have added py-rust-stemmers = "^0.1.0" https://github.com/qdrant/fastembed/commits/main/pyproject.toml this py-rust-stemmers is failing the build with the below error.

× Preparing metadata (pyproject.toml) did not run successfully.
#15 139.9   │ exit code: 1
#15 139.9   ╰─> [6 lines of output]
#15 139.9       
#15 139.9       Cargo, the Rust package manager, is not installed or is not on PATH.
#15 139.9       This package requires Rust and Cargo to compile extensions. Install it through
#15 139.9       the system's package manager or via https://rustup.rs/
#15 139.9       
#15 139.9       Checking for Rust toolchain....
#15 139.9       [end of output]
#15 139.9   
#15 139.9   note: This error originates from a subprocess, and is likely not a problem with pip.
#15 139.9 error: metadata-generation-failed
#15 139.9 
#15 139.9 × Encountered error while generating package metadata.
#15 139.9 ╰─> See above for output.
#15 139.9 
#15 139.9 note: This is an issue with the package mentioned above, not pip.
#15 139.9 hint: See above for details.
#15 139.9 

To fix this i have to install the fastembed==0.3.6 and lock it in my requirements.txt before installing nemoguardrails

Steps To Reproduce

qdrant/fastembed#366 (comment)

Expected Behavior

It is should install fastembed==0.4.0 if you want the latest working version

Actual Behavior

Build failing due to py-rust-stemmer package

@DixitAdh DixitAdh added the bug Something isn't working label Oct 23, 2024
@Pouyanpi Pouyanpi self-assigned this Oct 23, 2024
@Pouyanpi
Copy link
Collaborator

Thank you @DixitAdh for reporting this. We'll do as suggested 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants