Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to reshard non-contiguous inputs. #3071

Open
wujingyue opened this issue Sep 30, 2024 · 1 comment
Open

Unable to reshard non-contiguous inputs. #3071

wujingyue opened this issue Sep 30, 2024 · 1 comment
Assignees

Comments

@wujingyue
Copy link
Collaborator

wujingyue commented Sep 30, 2024

I found this when creating a test for something else. Most existing tests exercise contiguous input tensors, so this issue hasn't been caught so far, I think.

Repro:

Apply #3070.

$ _bn && mpirun -np 2 bin/test_multidevice --gtest_filter=MultiDeviceTest.NonContiguous

-np 1 repros too so you can run this on a single-GPU workstation.

@wujingyue
Copy link
Collaborator Author

This appears to be a limitation in make_resharding_contiguous or insert_reshardings. We can decompose the set into a non-resharding set that makes the tensor contiguous followed by a resharding, all-gather set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants