Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to enable leading underscore in op name #4405

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Oct 31, 2022

Category: Bug fix

Description:

Leading underscores in operator and module names were doubled.

Extracted from #4359 where leading underscore is actually used in module/operator name.

Additional information:

Affected modules and functionalities:

A bit of CamelCase to snake_case conversion.

Key points relevant for the review:

N/A

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL JanuszL self-assigned this Oct 31, 2022
@klecki
Copy link
Contributor Author

klecki commented Nov 2, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6362784]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6362784]: BUILD PASSED

@klecki klecki merged commit 45a5885 into NVIDIA:main Nov 3, 2022
@JanuszL JanuszL mentioned this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants