Fix fn.coord_transform handling of a default matrix in variable batch case #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [5005840]: BUILD STARTED |
|
CI MESSAGE: [5005840]: BUILD PASSED |
banasraf
approved these changes
Jun 7, 2022
mzient
reviewed
Jun 17, 2022
| Repeat(per_sample_mtx_, mtx_, N); | ||
| if (is_fused) { | ||
| translation_.resize(output_pt_dim_, 0); | ||
| Repeat(per_sample_translation_, translation_, N); |
There was a problem hiding this comment.
Won't this always be zero-filled?
Suggested change
| Repeat(per_sample_translation_, translation_, N); | |
| per_sample_translation_.resize(N * output_pt_dim_, 0); |
Signed-off-by: Kamil Tokarski <[email protected]>
Signed-off-by: Kamil Tokarski <[email protected]>
stiepan
force-pushed
the
fix_vb_coord_trans
branch
from
49e7eb8 to
b5917dc
Compare
|
!build |
|
CI MESSAGE: [5111952]: BUILD STARTED |
|
CI MESSAGE: [5111952]: BUILD FAILED |
|
CI MESSAGE: [5111952]: BUILD PASSED |
szalpal
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kamil Tokarski [email protected]
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
If M is not specified, its value is assumed to be id matrix and it is repeated as a per-sample arg to match the current batch size. However, if the dimensionality of data does not change, it is done only once, so if the batch size increases in the following iterations, the matrix is read out of vector bounds.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2816