Skip to content

Commit

Permalink
Disable some JAX iterator tests in sanitizer run (#5427)
Browse files Browse the repository at this point in the history
Signed-off-by: Kamil Tokarski <[email protected]>
  • Loading branch information
stiepan authored Apr 16, 2024
1 parent 2f4775d commit 93f1133
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
17 changes: 14 additions & 3 deletions qa/TL0_FW_iterators/test_jax.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,23 @@ do_once() {
}

test_body() {
# General tests for iterators
${python_new_invoke_test} -A 'jax' test_fw_iterators
# Updating JAX 0.4.13 -> 0.4.16 (or the most recent 0.4.26) causes
# asan to fail with suposed stack-overflow
# TODO(ktokarski) Investigate what may be the underlying cause
if [ -z "$DALI_ENABLE_SANITIZERS" ]; then
# General tests for iterators
${python_new_invoke_test} -A 'jax' test_fw_iterators
fi

# More specific JAX tests
${python_new_invoke_test} -s jax_plugin/ test_integration test_iterator test_peekable_iterator
${python_new_invoke_test} checkpointing.test_dali_checkpointing_fw_iterators.TestJax

# Updating JAX 0.4.13 -> 0.4.16 (or the most recent 0.4.26) causes
# asan to fail with suposed stack-overflow
# TODO(ktokarski) Investigate what may be the underlying cause
if [ -z "$DALI_ENABLE_SANITIZERS" ]; then
${python_new_invoke_test} checkpointing.test_dali_checkpointing_fw_iterators.TestJax
fi
}

pushd ../..
Expand Down
2 changes: 1 addition & 1 deletion qa/setup_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ def get_pyvers_name(self, url, cuda_version):
PckgVer(
"0.4.13", python_min_ver="3.8", python_max_ver="3.8", dependencies=["jaxlib"]
),
# dax.fn.jax_function requires 0.4.16 which is the first one supporting
# dax.fn.jax_function requires at least 0.4.16 which is the first one supporting
# `__dlpack__` method, while 0.4.13 is the last one supported with Python3.8
PckgVer("0.4.16", python_min_ver="3.9", dependencies=["jaxlib"]),
]
Expand Down

0 comments on commit 93f1133

Please sign in to comment.