Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1: Simplify the existing API #542

Closed
Tracked by #505
nzarif opened this issue Nov 19, 2022 · 0 comments · Fixed by #543
Closed
Tracked by #505

Part 1: Simplify the existing API #542

nzarif opened this issue Nov 19, 2022 · 0 comments · Fixed by #543
Assignees
Labels
area/api enhancement New feature or request
Milestone

Comments

@nzarif
Copy link
Contributor

nzarif commented Nov 19, 2022

This part includes 3 tasks:

  • Set the model to the inference mode by default + ensure training script is not impacted + update failing unit-tests

  • Remove the hf-format from Next Item Prediction task + ensure training / inference are not impacted + update failing unit-tests

  • Replace ignore_masking with testing flag + ensure training / inference are not impacted + update failing unit-tests

P.S: This PR removes the hf_format only for NextItemPredictionTask. Other tasks such as BinaryClassificationTask and RegressionTask still use hf_format as removing the flag for them at this stage does not make sense for them, they use the PredictionTask.forward() only for inference and use compute_loss() for training and eval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants