-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEA action diagnostics and status updates #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aromanielloNTIA
requested review from
jhazentia
and removed request for
dboulware
January 26, 2023 21:38
digital inputs, if not configured, return 0 and do not cause ValueErrors.
Closed
jhazentia
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
from scos_actions.settings import SENSOR_CALIBRATION_FILE, SIGAN_CALIBRATION_FILE | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
def get_sigan_calibration(sigan_cal_file): | ||
def get_sigan_calibration(sigan_cal_file: Path) -> Calibration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_sigan_calibration()
and get_sensor_calibration()
appear to be nearly the same. Consider combining in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCOS Actions updates (general):
Updates to the SEA data product action:
"scos_uptime_days"
and"scos_start_time"
to computer diagnostics metadata"uptime_hours"
computer uptime diagnostic field to"cpu_uptime_days"
, to distinguish from newly added SCOS uptime field and match its unitsUpdates to the SEA metadata format:
data_products
containing processing details for each type of data result, and the IIR filter being used. This reduces redundancy in each metadata file while including more information relevant to the processing.After merging, a new release should be built and a new equivalent tagged version
sea-prototype-v0.3
should be created.Merging this PR closes #62
Tested and working on seadog01