Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEA action diagnostics and status updates #66

Merged
merged 34 commits into from
Feb 7, 2023

Conversation

aromanielloNTIA
Copy link
Member

@aromanielloNTIA aromanielloNTIA commented Jan 26, 2023

SCOS Actions updates (general):

Updates to the SEA data product action:

  • Implements error handling for reading web relay sensors. If the sensor is not configured or returns a "X.X" value, the Exception is skipped and "Unavailable" is marked in the metadata.
  • Add "scos_uptime_days" and "scos_start_time" to computer diagnostics metadata
  • Convert previous "uptime_hours" computer uptime diagnostic field to "cpu_uptime_days", to distinguish from newly added SCOS uptime field and match its units

Updates to the SEA metadata format:

  • The metadata version is updated to v0.3
  • Moves data component sample counts to global level
  • Moves mean and max channel power summary statistics to global level
  • Adds global level object data_products containing processing details for each type of data result, and the IIR filter being used. This reduces redundancy in each metadata file while including more information relevant to the processing.
  • Updates diagnostics metadata: convert CPU uptime to days, add fields for SCOS start time and SCOS uptime
  • Changes overall reduce metadata size by about 35%, from 20 KB to 13 KB

After merging, a new release should be built and a new equivalent tagged version sea-prototype-v0.3 should be created.

Merging this PR closes #62

Tested and working on seadog01

@aromanielloNTIA aromanielloNTIA requested review from jhazentia and removed request for dboulware January 26, 2023 21:38
@aromanielloNTIA aromanielloNTIA marked this pull request as draft January 26, 2023 22:40
@aromanielloNTIA aromanielloNTIA mentioned this pull request Jan 31, 2023
@aromanielloNTIA aromanielloNTIA marked this pull request as ready for review January 31, 2023 21:54
Copy link
Member

@jhazentia jhazentia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

from scos_actions.settings import SENSOR_CALIBRATION_FILE, SIGAN_CALIBRATION_FILE

logger = logging.getLogger(__name__)


def get_sigan_calibration(sigan_cal_file):
def get_sigan_calibration(sigan_cal_file: Path) -> Calibration:
Copy link
Member

@jhazentia jhazentia Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_sigan_calibration() and get_sensor_calibration() appear to be nearly the same. Consider combining in the future.

@aromanielloNTIA aromanielloNTIA removed the request for review from dboulware February 7, 2023 18:29
@aromanielloNTIA aromanielloNTIA merged commit 2df838e into master Feb 7, 2023
@aromanielloNTIA aromanielloNTIA deleted the diagnostics-and-status-updates branch February 7, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCOS Sensor uptime not recorded in SEA action metadata
3 participants