Support multiple web relays, provide dynamic status, and enable signal analyzer power cycling. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s signal to allow things that can report status to be registered within scos-sensor. Adds configurable action to set switch states.
…th_status signal in constructor.
… added type to status.
…s before anything that could provide status is created.
…f MockSignalAnalyzer to discover to supply to test actions. Only register mock signal analyzer for status if running with mock sigan.
…e in power_cycle.
…actions into MultiSwitchStatus
aromanielloNTIA
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables sensors to include multiple web-relays, provide dynamic status for any number of components, and enables power cycling of the signal analyzer. To allow for any number of web-relays, this PR adds a SWITCH_CONFIGS_DIR variable to the settings. The variable will default to None or the value of the SWITCH_CONFIGS_DIR in the environment and will be replaced with the value supplied by Django/scos-sensor if it is set. Any web relay config files placed in the specified directory will be loaded and added to a switches dictionary in the hardware package. A SIGAN_POWER_SWITCH setting is added to optionally hold the id of the web relay that controls power to the signal analyzer and a SIGAN_POWER_CYCLE_STATES setting was added to optionally store the sequence of preselector states to set to power cycle the sigan. To support dynamic status, a register_component_with_status signal and associated handler were added to allow components to be dynamically registered to provide status. The capabilities are moved into their own package to prevent the expensive loading with the settings that are frequently used. Finally, I removed the default usage of the MockSignalAnalyzer from the actions to prevent developers from accidentally using the mock sigan.