This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
modeline by nvim 0.5 is as secure #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vim's modeline was known to be security risk. Arbitrary code execution issue was initially addressed by Vim upstream using sandbox approach. Nvim developer found security bug in this sandboxing code. This history made Nvim to disable this feature. Vim distributors such as Debian also disable this feature in its default install, too. Considering the recent change[*] to use more restrictive whitelist approach, use of modeline became as secure as external packages such as securemodelines written in vimL. [*] neovim/neovim#2865 Signed-off-by: Osamu Aoki <[email protected]>
NTBBloodbath
added
branch: develop
NTBBloodbath
approved these changes
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a patch for #134
Mode line is lines such as
# vim:set ai si ts=2 sts=2 sw=2 et:This can set vim some limitted options.
Vim's modeline was known to be security risk.
Arbitrary code execution issue was initially addressed by Vim upstream
using sandbox approach. Nvim developer found security bug in this
sandboxing code. This history made Nvim to disable this feature. Vim
distributors such as Debian also disable this feature in its default
install, too.
Considering the recent change[*] to use more restrictive whitelist
approach, use of modeline became as secure as external packages
such as securemodelines written in vimL.
[*] neovim/neovim#2865
Signed-off-by: Osamu Aoki [email protected]