Fix UnmetLoads measure for OS 3.0 and newer #168
Conversation
|
@DavidGoldwasser I made the change and re-enabled the tests, but two of the tests are failing. They seem unrelated to my change, so I will let you decide what to do about them. I'm not familiar enough with the measure to know what's going on. |
| exit_temp = plantloop.sizingPlant.getDesignLoopExitTemperature.value | ||
| exit_temp = plantloop.sizingPlant.designLoopExitTemperature |
There was a problem hiding this comment.
Found this today again: #175 (comment)
via https://unmethours.com/question/100084/cannot-run-unmet-load-hours-troubleshooting-measure/
| @@ -443,6 +444,8 @@ def time_series_setpoint_vs_temp(zoneMetrics) | |||
| @test_nine_data << graph | |||
| end | |||
| end | |||
|
|
|||
| attr_reader :measureMetrics | |||
There was a problem hiding this comment.
Needed for the measure unit tests to work
| <identifier>2.0.0</identifier> | ||
| <min_compatible>2.0.0</min_compatible> | ||
| <identifier>3.0.0</identifier> | ||
| <min_compatible>3.0.0</min_compatible> |
| require 'openstudio' | ||
| require 'openstudio/measure/ShowRunnerOutput' |
There was a problem hiding this comment.
Re-enabled all tests (but two still fail).
|
@DavidGoldwasser @shorowit It looks like Scott's pull request had some merge conflicts to resolve. |
|
@aaron-boranian Thanks for pinging this. I'll look at merge conflicts and see if I can get tests passing and this merged |
Merges of measure.xml files always messes this up.
|
Not sure why I'm getting failures or errors in 7 measures when only one was changed. Try CI run of clean develop see what is happening, and run locally.
|
|
I started to look at this hoping to get in 3.9.0 but not sure if I'll get it in time. First I remember whey the test was commented out, it overwrites some OpenStudio methods like This was one of first reporting measures and was using pre-made SQL file which was fine at the time, but now all reporting measures run a simulation and make a fresh SQL file as part of the test. I'll update this measure to do that but may not have time to do it in time to release with update for OpenStudio 3.9.0. Another thing I noticed is the test SQL file results in 0 unmet hours which makes it hard to see much. That may be because it is old SQL file not being read correctly. Maybe will have more populated HTML with a new model. 
|
Fixes #76